chore: revert changes introduced by allowing stopping services in starting state #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit acaacb2.
benhoyt
approved these changes
Oct 14, 2024
IronCore864
added a commit
to IronCore864/pebble
that referenced
this pull request
Oct 18, 2024
…s in starting state (canonical#510)" This reverts commit c3cb594.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we introduced a feature to allow stopping services that are in the starting state / within the okayDelay. However, this makes a deadlock issue in ringbuffer a real issue. So we are reverting this change now and will redo it after the deadlock is resolved.