Skip to content

Commit

Permalink
plugins v1: pin pip to supported versions (#3428)
Browse files Browse the repository at this point in the history
pip 21 dropped support for python 3.5 and python 2.

pip >=21 no longer support python3.5 or python 2 and if used will result in a
broken install with pip unable to install packages.

* Drop support for Python 3.5 pypa/pip#9189
* Drop support for Python 2 pypa/pip#6148
  • Loading branch information
philroche authored Jan 26, 2021
1 parent b5138e0 commit 007e41b
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion snapcraft/plugins/v1/_python/_pip.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,12 @@ def _ensure_pip_installed(self):
self.__python_home = os.path.join(os.path.sep, "usr")

# Using the host's pip, install our own pip
self.download({"pip"})
# pip >=21 no longer support python3.5 or python 2 and if
# used will result in a broken install with pip unable to
# install packages.
self.download(
{'pip; python_version >= "3.6"', 'pip<21; python_version < "3.6"'}
)
self.install({"pip"}, ignore_installed=True)
finally:
# Now that we have our own pip, reset the python home
Expand Down

0 comments on commit 007e41b

Please sign in to comment.