tests/lib/tools/store-state: exit on errors, update relevant tests #14725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboozzoo
added
Simple 😃
zyga
approved these changes
Nov 14, 2024
| @@ -28,6 +28,8 @@ prepare: | | |||
| snap debug can-manage-refreshes | MATCH false | |||
|
|
|||
| snap ack "$TESTSLIB/assertions/testrootorg-store.account-key" | |||
| snap ack "$TESTSLIB/assertions/developer1.account" | |||
There was a problem hiding this comment.
Will this ack work when we are running non-test keys build (aka a vanilla build)?
There was a problem hiding this comment.
there's if [ "$TRUST_TEST_KEYS" = "false" ]; then above
| @@ -1,5 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -e | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14725 +/- ##
==========================================
+ Coverage 78.95% 79.03% +0.07%
==========================================
Files 1084 1087 +3
Lines 146638 147628 +990
==========================================
+ Hits 115773 116671 +898
- Misses 23667 23728 +61
- Partials 7198 7229 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Maciej Borzecki <[email protected]> tests/lib/tools/store-state: use gojq Signed-off-by: Maciej Borzecki <[email protected]>
…loper1 assertions Signed-off-by: Maciej Borzecki <[email protected]>
Signed-off-by: Maciej Borzecki <[email protected]>
…ore using fake store Signed-off-by: Maciej Borzecki <[email protected]>
bboozzoo
force-pushed
the
bboozzoo/store-state-fixes
branch
from
0b54bad to
c0fe6da
Compare
The ping is best effort, and is only helpful when later requests will exercise parts of the API related to lookup of snaps that aren't already installed. However, in the tests, all relevant dependencies should be installed beforehand anyway. Signed-off-by: Maciej Borzecki <[email protected]>
|
Failures:
|
sespiros
added a commit
to sespiros/snapd
that referenced
this pull request
Nov 19, 2024
* master: (44 commits) wrappers: do not reload activation units (canonical#14724) gadget/install: support for no{exec,dev,suid} mount flags interfaces/builtin/mount_control: add support for nfs mounts (canonical#14694) tests: use gojq - part 1 (canonical#14686) interfaces/desktop-legacy: allow DBus access to com.canonical.dbusmenu interfaces/builtin/fwupd.go: allow access to nvmem for thunderbolt plugin tests: removing uc16 executions (canonical#14575) tests: Added arm github runner to build snapd (canonical#14504) tests: no need to run spread when there are not tests matching the filter (canonical#14728) tests/lib/tools/store-state: exit on errors, update relevant tests (canonical#14725) tests: udpate the github workflow to run tests suggested by spread-filter tool (canonical#14519) testtime: add mockable timers for use in tests (canonical#14672) interface/screen_inhibit_control: Improve screen inhibit control for use on core (canonical#14134) tests: use images with 20G disk in openstack (canonical#14720) i/builtin: allow @ in custom-device filepaths (canonical#14651) tests: refactor test-snapd-desktop-layout-with-content tests: fix broken app definition tests: capitalize sentences in comments tests: wrap very long shell line tests: fix raciness in async startup and sync install ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
set -ein the store-state tool to catch errors. Fix failing tests. Update tests/main/store-state to use core22 instead of core for the test snap.Cherry picked from #14686