Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for cds.Map #889

Merged
merged 15 commits into from
Jan 17, 2025
Merged

feat: support for cds.Map #889

merged 15 commits into from
Jan 17, 2025

Conversation

SamuelBrucksch
Copy link
Contributor

@SamuelBrucksch SamuelBrucksch commented Nov 12, 2024 •
edited
Loading

As Map type also has elements, we get into that if and then it is ignored. So I added a check, to pass through map type, so it is handled like a normal ref.

@SamuelBrucksch SamuelBrucksch changed the title pass through map type as normal ref fix: pass through map type as normal ref Nov 12, 2024
@patricebender
Copy link
Member

patricebender commented Nov 12, 2024 •
edited
Loading

I think for this change to work we need at least compiler v5.4.0

@johannes-vogel
Copy link
Contributor

I've merged main branch now which uses already newest cds+compiler versions

@johannes-vogel johannes-vogel changed the title fix: pass through map type as normal ref feat: support for cds.Map Dec 17, 2024
@johannes-vogel
Copy link
Contributor

@BobdenOs I've tried to fix the remaining HANA failure but I think we need to have a look together.

@johannes-vogel

This comment was marked as outdated.

Sign in to view
@johannes-vogel johannes-vogel added the next release pr to be checked for next release label Jan 16, 2025
@johannes-vogel johannes-vogel marked this pull request as ready for review January 17, 2025 13:35
@johannes-vogel johannes-vogel enabled auto-merge (squash) January 17, 2025 13:36
@johannes-vogel johannes-vogel merged commit cde7514 into main Jan 17, 2025
3 of 4 checks passed
@johannes-vogel johannes-vogel deleted the map-type branch January 17, 2025 13:54
@cap-bots cap-bots mentioned this pull request Jan 17, 2025
Merged
johannes-vogel added a commit that referenced this pull request Jan 28, 2025
@cap-bots @johannes-vogel
chore: release main (#961)
0b1b533 
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.17.0</summary>

##
[1.17.0](db-service-v1.16.2...db-service-v1.17.0)
(2025-01-27)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* **`UPDATE`:** no assocs in list which matches subquery results
([4bcb88a](4bcb88a))
* **`UPDATE`:** only perform subselect matching if necessary
([#989](#989))
([4bcb88a](4bcb88a))
* contains not evaluting to bool
([#980](#980))
([760484b](760484b))
* nested ternary in calculated element
([#981](#981))
([5f4a1fe](5f4a1fe))
* reject virtual elements in all expressions
([#972](#972))
([d0c949d](d0c949d))
* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
* use "$$value$$" as internal column name for UPSERT
([#976](#976))
([8c86b86](8c86b86))
</details>

<details><summary>sqlite: 1.8.0</summary>

##
[1.8.0](sqlite-v1.7.8...sqlite-v1.8.0)
(2025-01-27)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))
</details>

<details><summary>postgres: 1.11.0</summary>

##
[1.11.0](postgres-v1.10.5...postgres-v1.11.0)
(2025-01-27)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
</details>

<details><summary>hana: 1.6.0</summary>

##
[1.6.0](hana-v1.5.2...hana-v1.6.0)
(2025-01-27)


### Added

* support driver self-wrapping (for Dynatrace)
([#974](#974))
([5346bc4](5346bc4))
* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* Fix expand aliasing
([#959](#959))
([f39097c](f39097c))
* groupby path expression with overlapping identifier
([#992](#992))
([b579da8](b579da8))
* multi raw SQL queries
([#973](#973))
([b953480](b953480))
* Remove `orderBy` ref check for `sql_simple_queries`
([#964](#964))
([1b77725](1b77725))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Johannes Vogel <[email protected]>
This was referenced Jan 28, 2025
Closed
Merged
johannes-vogel added a commit that referenced this pull request Jan 28, 2025
@cap-bots @johannes-vogel
chore: release main (#999)
c8284d1 
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.17.0</summary>

##
[1.17.0](db-service-v1.16.2...db-service-v1.17.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* **`UPDATE`:** no assocs in list which matches subquery results
([4bcb88a](4bcb88a))
* **`UPDATE`:** only perform subselect matching if necessary
([#989](#989))
([4bcb88a](4bcb88a))
* contains not evaluting to bool
([#980](#980))
([760484b](760484b))
* nested ternary in calculated element
([#981](#981))
([5f4a1fe](5f4a1fe))
* reject virtual elements in all expressions
([#972](#972))
([d0c949d](d0c949d))
* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
* use "$$value$$" as internal column name for UPSERT
([#976](#976))
([8c86b86](8c86b86))
</details>

<details><summary>sqlite: 1.8.0</summary>

##
[1.8.0](sqlite-v1.7.8...sqlite-v1.8.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))
</details>

<details><summary>postgres: 1.11.0</summary>

##
[1.11.0](postgres-v1.10.5...postgres-v1.11.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
</details>

<details><summary>hana: 1.6.0</summary>

##
[1.6.0](hana-v1.5.2...hana-v1.6.0)
(2025-01-28)


### Added

* support driver self-wrapping (for Dynatrace)
([#974](#974))
([5346bc4](5346bc4))
* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* Fix expand aliasing
([#959](#959))
([f39097c](f39097c))
* groupby path expression with overlapping identifier
([#992](#992))
([b579da8](b579da8))
* multi raw SQL queries
([#973](#973))
([b953480](b953480))
* Remove `orderBy` ref check for `sql_simple_queries`
([#964](#964))
([1b77725](1b77725))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Johannes Vogel <[email protected]>
This was referenced Jan 28, 2025
Closed
Merged
johannes-vogel added a commit that referenced this pull request Jan 28, 2025
@cap-bots @johannes-vogel
chore: release main (#1001)
6c4b539 
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.17.0</summary>

##
[1.17.0](db-service-v1.16.2...db-service-v1.17.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* **`UPDATE`:** no assocs in list which matches subquery results
([4bcb88a](4bcb88a))
* **`UPDATE`:** only perform subselect matching if necessary
([#989](#989))
([4bcb88a](4bcb88a))
* contains not evaluting to bool
([#980](#980))
([760484b](760484b))
* nested ternary in calculated element
([#981](#981))
([5f4a1fe](5f4a1fe))
* reject virtual elements in all expressions
([#972](#972))
([d0c949d](d0c949d))
* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
* use "$$value$$" as internal column name for UPSERT
([#976](#976))
([8c86b86](8c86b86))
</details>

<details><summary>sqlite: 1.8.0</summary>

##
[1.8.0](sqlite-v1.7.8...sqlite-v1.8.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))
</details>

<details><summary>postgres: 1.11.0</summary>

##
[1.11.0](postgres-v1.10.5...postgres-v1.11.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
</details>

<details><summary>hana: 1.6.0</summary>

##
[1.6.0](hana-v1.5.2...hana-v1.6.0)
(2025-01-28)


### Added

* support driver self-wrapping (for Dynatrace)
([#974](#974))
([5346bc4](5346bc4))
* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* Fix expand aliasing
([#959](#959))
([f39097c](f39097c))
* groupby path expression with overlapping identifier
([#992](#992))
([b579da8](b579da8))
* multi raw SQL queries
([#973](#973))
([b953480](b953480))
* Remove `orderBy` ref check for `sql_simple_queries`
([#964](#964))
([1b77725](1b77725))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Johannes Vogel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobdenOs BobdenOs BobdenOs approved these changes

@patricebender patricebender Awaiting requested review from patricebender patricebender is a code owner

@gregorwolf gregorwolf Awaiting requested review from gregorwolf gregorwolf is a code owner

@sebastianesch sebastianesch Awaiting requested review from sebastianesch sebastianesch is a code owner

@vobu vobu Awaiting requested review from vobu vobu is a code owner

@danjoa danjoa Awaiting requested review from danjoa danjoa is a code owner

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel johannes-vogel is a code owner

@stewsk stewsk Awaiting requested review from stewsk stewsk is a code owner

@sjvans sjvans Awaiting requested review from sjvans sjvans is a code owner

@David-Kunz David-Kunz Awaiting requested review from David-Kunz David-Kunz is a code owner

Assignees
No one assigned
Labels
next release pr to be checked for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamuelBrucksch @patricebender @johannes-vogel @BobdenOs