fix: use "$$value$$" as internal column name for UPSERT #976
+57
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes it less probable that we run into an ambiguous column error upon deployment. fixes #931
patricebender
commented
Jan 22, 2025
patricebender
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs,
sjvans and
David-Kunz
as code owners
BobdenOs
approved these changes
Jan 23, 2025
Merged
johannes-vogel
added a commit
that referenced
this pull request
Jan 28, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.17.0</summary> ## [1.17.0](db-service-v1.16.2...db-service-v1.17.0) (2025-01-27) ### Added * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) ### Fixed * **`UPDATE`:** no assocs in list which matches subquery results ([4bcb88a](4bcb88a)) * **`UPDATE`:** only perform subselect matching if necessary ([#989](#989)) ([4bcb88a](4bcb88a)) * contains not evaluting to bool ([#980](#980)) ([760484b](760484b)) * nested ternary in calculated element ([#981](#981)) ([5f4a1fe](5f4a1fe)) * reject virtual elements in all expressions ([#972](#972)) ([d0c949d](d0c949d)) * starts endswith for null values ([#975](#975)) ([f0330bc](f0330bc)) * use "$$value$$" as internal column name for UPSERT ([#976](#976)) ([8c86b86](8c86b86)) </details> <details><summary>sqlite: 1.8.0</summary> ## [1.8.0](sqlite-v1.7.8...sqlite-v1.8.0) (2025-01-27) ### Added * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) </details> <details><summary>postgres: 1.11.0</summary> ## [1.11.0](postgres-v1.10.5...postgres-v1.11.0) (2025-01-27) ### Added * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) ### Fixed * starts endswith for null values ([#975](#975)) ([f0330bc](f0330bc)) </details> <details><summary>hana: 1.6.0</summary> ## [1.6.0](hana-v1.5.2...hana-v1.6.0) (2025-01-27) ### Added * support driver self-wrapping (for Dynatrace) ([#974](#974)) ([5346bc4](5346bc4)) * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) ### Fixed * Fix expand aliasing ([#959](#959)) ([f39097c](f39097c)) * groupby path expression with overlapping identifier ([#992](#992)) ([b579da8](b579da8)) * multi raw SQL queries ([#973](#973)) ([b953480](b953480)) * Remove `orderBy` ref check for `sql_simple_queries` ([#964](#964)) ([1b77725](1b77725)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Johannes Vogel <[email protected]>
johannes-vogel
added a commit
that referenced
this pull request
Jan 28, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.17.0</summary> ## [1.17.0](db-service-v1.16.2...db-service-v1.17.0) (2025-01-28) ### Added * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) ### Fixed * **`UPDATE`:** no assocs in list which matches subquery results ([4bcb88a](4bcb88a)) * **`UPDATE`:** only perform subselect matching if necessary ([#989](#989)) ([4bcb88a](4bcb88a)) * contains not evaluting to bool ([#980](#980)) ([760484b](760484b)) * nested ternary in calculated element ([#981](#981)) ([5f4a1fe](5f4a1fe)) * reject virtual elements in all expressions ([#972](#972)) ([d0c949d](d0c949d)) * starts endswith for null values ([#975](#975)) ([f0330bc](f0330bc)) * use "$$value$$" as internal column name for UPSERT ([#976](#976)) ([8c86b86](8c86b86)) </details> <details><summary>sqlite: 1.8.0</summary> ## [1.8.0](sqlite-v1.7.8...sqlite-v1.8.0) (2025-01-28) ### Added * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) </details> <details><summary>postgres: 1.11.0</summary> ## [1.11.0](postgres-v1.10.5...postgres-v1.11.0) (2025-01-28) ### Added * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) ### Fixed * starts endswith for null values ([#975](#975)) ([f0330bc](f0330bc)) </details> <details><summary>hana: 1.6.0</summary> ## [1.6.0](hana-v1.5.2...hana-v1.6.0) (2025-01-28) ### Added * support driver self-wrapping (for Dynatrace) ([#974](#974)) ([5346bc4](5346bc4)) * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) ### Fixed * Fix expand aliasing ([#959](#959)) ([f39097c](f39097c)) * groupby path expression with overlapping identifier ([#992](#992)) ([b579da8](b579da8)) * multi raw SQL queries ([#973](#973)) ([b953480](b953480)) * Remove `orderBy` ref check for `sql_simple_queries` ([#964](#964)) ([1b77725](1b77725)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Johannes Vogel <[email protected]>
johannes-vogel
added a commit
that referenced
this pull request
Jan 28, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.17.0</summary> ## [1.17.0](db-service-v1.16.2...db-service-v1.17.0) (2025-01-28) ### Added * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) ### Fixed * **`UPDATE`:** no assocs in list which matches subquery results ([4bcb88a](4bcb88a)) * **`UPDATE`:** only perform subselect matching if necessary ([#989](#989)) ([4bcb88a](4bcb88a)) * contains not evaluting to bool ([#980](#980)) ([760484b](760484b)) * nested ternary in calculated element ([#981](#981)) ([5f4a1fe](5f4a1fe)) * reject virtual elements in all expressions ([#972](#972)) ([d0c949d](d0c949d)) * starts endswith for null values ([#975](#975)) ([f0330bc](f0330bc)) * use "$$value$$" as internal column name for UPSERT ([#976](#976)) ([8c86b86](8c86b86)) </details> <details><summary>sqlite: 1.8.0</summary> ## [1.8.0](sqlite-v1.7.8...sqlite-v1.8.0) (2025-01-28) ### Added * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) </details> <details><summary>postgres: 1.11.0</summary> ## [1.11.0](postgres-v1.10.5...postgres-v1.11.0) (2025-01-28) ### Added * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) ### Fixed * starts endswith for null values ([#975](#975)) ([f0330bc](f0330bc)) </details> <details><summary>hana: 1.6.0</summary> ## [1.6.0](hana-v1.5.2...hana-v1.6.0) (2025-01-28) ### Added * support driver self-wrapping (for Dynatrace) ([#974](#974)) ([5346bc4](5346bc4)) * support for cds.Map ([#889](#889)) ([cde7514](cde7514)) ### Fixed * Fix expand aliasing ([#959](#959)) ([f39097c](f39097c)) * groupby path expression with overlapping identifier ([#992](#992)) ([b579da8](b579da8)) * multi raw SQL queries ([#973](#973)) ([b953480](b953480)) * Remove `orderBy` ref check for `sql_simple_queries` ([#964](#964)) ([1b77725](1b77725)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Johannes Vogel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes it less probable that we run into an ambiguous column error upon deployment.
fixes #931