-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update validation message if rbenv_ruby is not set #70
Update validation message if rbenv_ruby is not set #70
Conversation
Thanks for the PR! This project lacks automated tests, which makes reviewing and If you have not already done so, consider including output of your code running Thanks again for taking the time to improve Capistrano! 😃 Here's an example of a CHANGELOG.md entry (place it immediately under the * [#70](https://github.com/capistrano/rbenv/pull/70): Update validation message if rbenv_ruby is not set - [@ivanovaleksey](https://github.com/ivanovaleksey) Generated by 🚫 Danger |
@ivanovaleksey Good point! Thanks for the PR. @spikeheap Do you have an suggestion for if/how we should change the warning? It seems weird to warn the user when they are doing nothing wrong. |
bc64d8f
to
42c28ba
Compare
I have updated the message a little bit:
Shoudn't it be ... defined by the remote hosts instead of ... defined on remote hosts? |
Hi @ivanovaleksey, this PR looks good, particularly downgrading the message to This does alter the initial behaviour, which required 👍 |
@spikeheap thank you,
|
Hi @ivanovaleksey, I do love to bikeshed, so... IMHO your 'by' option above reads slightly better than the others, and highlights that rbenv is picked up on each host. They all make sense though :). |
42c28ba
to
46ffb9f
Compare
Looks good! Thanks for contribution ✨ |
Hi,
I use new capistrano/rbenv feature that allows not to define
rbenv_ruby
in config file.But the warning message wasn't updated and now it seems a little bit confusing to me.
If I intentionally removed
rbenv_ruby
from capistrano config "rbenv: rbenv_ruby is not set" looks like I still do something wrong.It is already said in README
So I think it would be better to add this notice directly to the message.
P. S.
I am not sure about words in the message. Is
remote hosts
better thandeployed hosts
?