Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #150

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Dec 13, 2024

After having talked with Caprover team I am proposing a PR to upgrade dependencies to most recent versions.

Something I cannot understand is:
chmod +x ./built -R

the -R attribute is supposed to go first, right after the chmod command, but I may be loosing the path here if we are building or using an image that does support that, but afaik, the correct format is after the command not at the end of it.
cc: @githubsaturn

Changelog

  1. Upgrading dependencies
  2. Small code refactor to sync with most recent versions installed
  3. Apply code linting & formatting with same rules that were established already.

PR Checks

  • Read the Contribution guidelines
  • Communicated with Caprover team by mail
  • Reduced changes as much as humanly possible
  • Made clean changes
  • My PR is well tested

only thing so far I have not completed is testing but probably community/caprover can help on that?

@githubsaturn
Copy link
Collaborator

Changes look good. Can you please fix the build errors so we can merge?

@elribonazo
Copy link
Contributor Author

elribonazo commented Dec 20, 2024

Yes sorry had not seen, ofc. Before merging also i think we should test more! I didn't have chance to test everything i wanted u maybe can help on that

@elribonazo
Copy link
Contributor Author

I could not reproduce the issue locally... but it not going to happen probably if we upgrade the CI pipelines to use higher versions of nodejs, it was currently used in node 14 and I upgraded to node 20.

@githubsaturn githubsaturn merged commit cc6c3ad into caprover:master Dec 23, 2024
1 of 2 checks passed
githubsaturn added a commit that referenced this pull request Dec 23, 2024
githubsaturn added a commit that referenced this pull request Dec 23, 2024
githubsaturn added a commit that referenced this pull request Dec 23, 2024
@githubsaturn
Copy link
Collaborator

No it wasn't related to node version. Looks like the problem was that somehow linter and formatter were fighting against each other.

@elribonazo elribonazo deleted the upgrade-dependencies branch December 24, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants