Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmailEngine app #676

Merged
merged 5 commits into from
Jul 7, 2022
Merged

Add EmailEngine app #676

merged 5 commits into from
Jul 7, 2022

Conversation

LWJerri
Copy link
Contributor

@LWJerri LWJerri commented Jul 5, 2022

First of all, thank you for your contribution! 😄

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.

Copy link
Collaborator

@githubsaturn githubsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Just one minor comment.

public/v4/apps/emailengine.yml Outdated Show resolved Hide resolved
@LWJerri LWJerri requested a review from githubsaturn July 7, 2022 14:19
@githubsaturn
Copy link
Collaborator

Thanks for the update. @LWJerri - you should also remove all instances of "cap_redis_password" in your yaml file now

@LWJerri
Copy link
Contributor Author

LWJerri commented Jul 7, 2022

Check failed. Do I need to fix it?

@githubsaturn
Copy link
Collaborator

Yes, just run the formatter and it'll fix it.

@LWJerri
Copy link
Contributor Author

LWJerri commented Jul 7, 2022

Yes, just run the formatter and it'll fix it.

It's strange, but all files have a normal style.
image

@LWJerri LWJerri requested a review from githubsaturn July 7, 2022 14:40
@githubsaturn githubsaturn merged commit b06a9b8 into caprover:master Jul 7, 2022
@githubsaturn
Copy link
Collaborator

Thank you!!

Tivin-i pushed a commit to SelfHosted-Club/caprover-one-click-apps that referenced this pull request May 19, 2023
* Add EmailEngine app

* Add EmailEngine logo

* Remove `--reguirepass` flag for Redis instance

* Update yml build file

* Apply Prettier style to emailengine.yml
@lexoyo
Copy link
Contributor

lexoyo commented Dec 31, 2024

I installed emailengine amd now i understand that we require a (paid) license to use it. It's not open source but source available right ?

@andris9
Copy link
Contributor

andris9 commented Dec 31, 2024

@lexoyo yes but you can use the tag v1.14.7 or older to get the AGPL licensed open source version that does not require a paid subscription. The v1 branch is very old though and is missing a lot of features.

@lexoyo
Copy link
Contributor

lexoyo commented Dec 31, 2024

@lexoyo yes but you can use the tag v1.14.7 or older to get the AGPL licensed open source version that does not require a paid subscription. The v1 branch is very old though and is missing a lot of features.

Thank you for your quick answer

I would argue that this does not have it's place in the community one-click-apps

Have a nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants