Small arm64 compat header fixes #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please also fix it in the header generator script and add these two to the test |
|
Allright, thanks for such a quick response |
|
Is that it? I couldn't find this test c file you were talking about to add it here ;/ |
|
@kabeor please merge this one |
|
@satk0 Can you rebase please? For whatever reason Github doesn't want to merge this one. |
|
Allright, give me 5 minutes |
satk0
force-pushed
the
compat-header-fixes
branch
from
e77acdf to
628f947
Compare
|
@Rot127 Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
...
First of all, thanks a lot for making those changes to arm64 compat header :)
I've tried to use the newest csnext in r2 and found some things missing so I've made this PR implementing it, hope it helps 😅