Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs):avt-1-guidelines-pictograms-usage-img #2149

Merged
merged 3 commits into from
Feb 23, 2021
Merged

fix(docs):avt-1-guidelines-pictograms-usage-img #2149

merged 3 commits into from
Feb 23, 2021

Conversation

andreancardona
Copy link
Contributor

Closes #1502

  • Adds an img alt text to Pictograms usage page to fix A11y violation

Testing

  • Run Accessibility Checker Guidelines --> Pictograms --> Usage page and make sure the violation seen in the issue no longer exists

@andreancardona andreancardona requested a review from a team February 19, 2021 18:23
@andreancardona andreancardona requested a review from a team as a code owner February 19, 2021 18:23
@vercel
Copy link

vercel bot commented Feb 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/B7Wco5eD8hcrrsWLLRM3AMHNLAv2
✅ Preview: https://carbondesignsy-git-fork-andreancardona-avt-1-guidelines-f9ee56.vercel.app

This was referenced Feb 19, 2021
Closed
Closed
tw15egan
tw15egan approved these changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@andreancardona andreancardona removed the request for review from dakahn February 19, 2021 19:42
@kodiakhq kodiakhq bot merged commit 1f3bcab into carbon-design-system:master Feb 23, 2021
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@andreancardona @alisonjoseph
@kodiakhq @natashadecoste
fix(docs):avt-1-guidelines-pictograms-usage-img (carbon-design-system…
3ffb5b2 
…#2149)

Co-authored-by: Alison Joseph <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@andreancardona @alisonjoseph
@kodiakhq @natashadecoste
fix(docs):avt-1-guidelines-pictograms-usage-img (carbon-design-system…
c91e85b 
…#2149)

Co-authored-by: Alison Joseph <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tw15egan tw15egan tw15egan approved these changes

@janchild janchild janchild approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit-avt1-guidelines-pictograms: img needs alt attribute
4 participants
@andreancardona @alisonjoseph @tw15egan @janchild