Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(List): add info on List expressive #2240

Merged
merged 8 commits into from
May 13, 2021
Merged

update(List): add info on List expressive #2240

merged 8 commits into from
May 13, 2021

Conversation

shixiedesign
Copy link
Contributor

@shixiedesign shixiedesign commented Apr 21, 2021 •
edited
Loading

Related #

Website update part 2/3

carbon-design-system/carbon#8301

Changelog

Changed

  • Style / Typography to mention the larger list.
  • FYI all classnames are guesswork and should be verified by devs!

@shixiedesign shixiedesign requested a review from a team April 21, 2021 15:59
@shixiedesign shixiedesign requested a review from a team as a code owner April 21, 2021 15:59
@vercel
Copy link

vercel bot commented Apr 21, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/Fb4dLqdojwGmrFWGjfaJ8F1Z4ak6
✅ Preview: https://carbondesignsy-git-fork-shixiedesign-list-expressive-car-7af9d7.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2021 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@shixiedesign
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@shixiedesign
Copy link
Contributor Author

recheck

@shixiedesign shixiedesign mentioned this pull request Apr 21, 2021
Closed
@janchild janchild mentioned this pull request Apr 23, 2021
Closed
janchild
janchild suggested changes May 12, 2021
View reviewed changes
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to make a content update first thing tomorrow. Just need to check one thing!

janchild
janchild approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in for type tokens and new intro paragraph for Typography section. This is good to go with the release.

@kodiakhq kodiakhq bot merged commit a0a2671 into carbon-design-system:main May 13, 2021
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@shixiedesign @janchild @natashadecoste
update(List): add info on List expressive (carbon-design-system#2240)
f45fcae 
* add to style/typography

* change short to long

* rewrite of intro para for typography

* type token update per PR8679

Co-authored-by: Jan Child <[email protected]>
Co-authored-by: Jan Child <[email protected]>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@shixiedesign @janchild @natashadecoste
update(List): add info on List expressive (carbon-design-system#2240)
b3c899b 
* add to style/typography

* change short to long

* rewrite of intro para for typography

* type token update per PR8679

Co-authored-by: Jan Child <[email protected]>
Co-authored-by: Jan Child <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@dakahn dakahn dakahn approved these changes

@janchild janchild janchild approved these changes

@jillianhowarth jillianhowarth Awaiting requested review from jillianhowarth

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shixiedesign @emyarod @dakahn @janchild