Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(typography): include expressive experience #2242

Closed
wants to merge 3 commits into from
Closed

update(typography): include expressive experience #2242

wants to merge 3 commits into from

Conversation

shixiedesign
Copy link
Contributor

@shixiedesign shixiedesign commented Apr 21, 2021 •
edited
Loading

Related #

carbon-design-system/carbon#8299

Changelog

Changed

  • Update Guideline / Typography page to include information and guidance on new expressive tokens
  • Added to TypesetStyle.js: caption-02, label-02, helper-text-02

@shixiedesign shixiedesign requested a review from a team April 21, 2021 17:25
@shixiedesign shixiedesign requested a review from a team as a code owner April 21, 2021 17:25
@vercel
Copy link

vercel bot commented Apr 21, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/CeRq28t66khdvYumZLPcijqx9bkh
✅ Preview: https://carbondesignsy-git-fork-shixiedesign-typography-exp-carb-e8d7fa.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2021 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@shixiedesign shixiedesign changed the title Update guideline: Typography page update(typography): include expressive experience Apr 21, 2021
@shixiedesign shixiedesign marked this pull request as draft April 21, 2021 17:26
@shixiedesign
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@shixiedesign
Copy link
Contributor Author

recheck

@shixiedesign shixiedesign mentioned this pull request Apr 21, 2021
Closed
@janchild janchild mentioned this pull request Apr 23, 2021
Closed
@janchild janchild mentioned this pull request Apr 30, 2021
Closed
94 tasks
@tay1orjones tay1orjones removed their request for review May 4, 2021 20:38
@janchild janchild mentioned this pull request May 13, 2021
Closed
87 tasks
@shixiedesign shixiedesign mentioned this pull request Jun 3, 2021
Closed
@janchild
Copy link
Contributor

Closing this PR for @shixiedesign. Will open a new draft PR to manage the changes made to the tables.

@janchild janchild closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janchild janchild Awaiting requested review from janchild

@andreancardona andreancardona Awaiting requested review from andreancardona

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shixiedesign @janchild