Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal cannot reflow to 400% zoom #3556

Closed
mbgower opened this issue Jul 26, 2019 · 4 comments
Closed

Modal cannot reflow to 400% zoom #3556

mbgower opened this issue Jul 26, 2019 · 4 comments

Comments

@mbgower
Copy link

mbgower commented Jul 26, 2019

Modal cannot reflow to 400% zoom

React

Windows 7 (also occurs in OSX)

Chrome (cannot reproduce in FF since it only zooms to 300%)

Detailed description

Zooming component causes text to increase in size (as expected) and several breakpoints to occur (as expected); however, the 'body' text (the lorem ipsum) will disappear entirely at 400% zoom.

What did you expect to happen?

The content should have reflowed so at least some of the body text, along with the vertical scrollbar that appeared, was still visible.

What happened instead?

The content reflowed but all the body text disappeared.

What WCAG 2.1 checkpoint does the issue violate?

Reflow

Steps to reproduce the issue

  1. using Chrome on a desktop, open modal in React http://react.carbondesignsystem.com/?path=/story/modal--default
  2. Zoom browser with Ctrl++ until it reaches 400%

Please create a reduced test case in CodeSandbox

Additional information

image
Modal at 300%. Text content in dialog still visible, wtih vertical scrollbar. Good behaviour.
image
Modal at 400%. Text content in dialog and scrollbar completely absent. Failure.

Occurs in react storybook, theme and v10 (carbondesignsystem.com)

I suspect one of the contributors to this issue is that the main content area does not include the full width of the dialog, but instead leaves substantial white space to the right of the scrollbar. If the full width of the dialog was used, the issue would likely be resolved.

@asudoh
Copy link
Contributor

asudoh commented Jul 26, 2019

CC @carbon-design-system/design to see their thoughts. Thanks!

@shixiedesign
Copy link
Contributor

This looks like a bug to me. The white space to the right of body copy should be 25% of modal width. When zoomed in, it should be treated the same as moving on to sm breakpoint, so the body copy should look like below:

image

@asudoh
Copy link
Contributor

asudoh commented Jul 31, 2019

Seems that the cause is the bottom margin of .bx--modal-content (seems 3rem) rather than the responsive styling. Below screenshot would be the best explanation:

image

@dakahn dakahn added this to the Modal - A11y Project Team milestone Sep 30, 2019
@dakahn dakahn modified the milestones: Modal - A11y Project Team, Carbon WCAG Compliance Nov 21, 2019
@asudoh
Copy link
Contributor

asudoh commented Nov 28, 2019

#4657 implements a new spec (#4607) that removes the right margin for smaller width. I can see modal body content remains with 400% zoom with the new UI.

@asudoh asudoh closed this as completed Nov 28, 2019
@mattrosno mattrosno removed this from the ♿Carbon WCAG Compliance♿ milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants