-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modal] Design enhancements - Ready #4607
Comments
Modal sizes
WidthsThe width's will vary based on breakpoint
% corollate to an approximate column count
Heights
Overflow contentUse a fade to indicate there is content below the fold Margin-right
|
Button groupsGuidance:
|
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
@emyarod I'm guessing these enhancements are only being made to React. Are their plans to carry them down to Vanilla (specifically the change so users can not click outside the transactional modal to close it)? |
@aagonzales looking at this comment (#4607 (comment)), what's the expected behavior of a keyboard users when they press |
Pressing |
@elizabethsjudd the visual changes should appear for both vanilla and React. I don't think the UX changes have been implemented yet in either library but I can port it to vanilla when it's done |
Thank you @emyarod! |
Introducing new modal enhancements and variations.
Check indicates dev delivered.
Sketch file:
https://ibm.box.com/s/38r605b633kvmpt5qcv67owqn6imfmhk
The text was updated successfully, but these errors were encountered: