Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] Focus outline now permanent on low contrast notifications #6053

Closed
richardpilot opened this issue May 8, 2020 · 2 comments · Fixed by #5978
Closed

[Notification] Focus outline now permanent on low contrast notifications #6053

richardpilot opened this issue May 8, 2020 · 2 comments · Fixed by #5978

Comments

@richardpilot
Copy link

Environment

Any

Detailed description

Issue #5737 was raised to changed the focus outline from white to blue, however the 'fix' was incorrect and is now permanently visible rather than only on :focus events.

This makes the low contrast button quite distracting and it now has visually different behaviour from high contrast.

Much like the original defect, it continues to break accessibility as the button still has no focus indicator.

What WCAG 2.1 checkpoint does the issue violate?
https://www.ibm.com/able/guidelines/ci162/focus_visible.html

Steps to reproduce the issue

  1. Navigate to https://react.carbondesignsystem.com/?path=/story/notifications--inline
  2. Check the low contrast knob
  3. focus on the close button, there is no visual change
@tw15egan
Copy link
Collaborator

Will be fixed in #6053

@tw15egan tw15egan linked a pull request May 11, 2020 that will close this issue
@joshblack joshblack assigned joshblack and unassigned joshblack May 12, 2020
@joshblack
Copy link
Contributor

Gonna close this out as a duplicate of #5977

Should be addressed in #5978 as TJ noted 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants