-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DataTable): fix small toolbar sizing and color bug #10296
fix(DataTable): fix small toolbar sizing and color bug #10296
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: cf8a596 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f85814943dea000879490d 😎 Browse the preview: https://deploy-preview-10296--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: cf8a596 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f858141fc448000844a8b5 😎 Browse the preview: https://deploy-preview-10296--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: cf8a596 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f858150b299400089895b8 😎 Browse the preview: https://deploy-preview-10296--carbon-components-react.netlify.app |
@jnm2377 oof, the data table stories were so chaotic, thank you for taking that on and re-organizing so it worked with |
@abbeyhrt updated the bugs you found 👍🏽 |
@abbeyhrt and @tay1orjones updated the styles, so v11 toolbar search icon should be aligned now. Sorry the PR files might be a little confusing with all the story changes. The fixes pertaining to this bug were really in 3 files:
The rest are story updates. |
…ble-toolbar-fixes
Mirroring the update from carbon-design-system#10535, $layer-disabled no longer exists.
Checks were failing due to updates pulled in from #10535. I pushed an update converting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!
Closes #10058
Changelog
DataTable-story.js
since storybook wasn't using those storiesOverflowMenu
v11 refactor wasn't adding the icon class name to the trigger icon, so it wasn't getting icon fill theming, which was also present in DataTableTesting / Reviewing