chore(button): size audit

[sstrubberg]

REF 10295

• Added FeatureFlag ternary for Button size prop based on guidance provided by design. REF
• Removed the defaultProps object and used default params REF
• Renamed ...other to ...rest for consistency with the rest of the codebase.
• Updated the public snappy and other tests because i moved the defaultProps.

Testing

• Make sure Button is behaving correctly in the v11 & v10 storybooks and that size props are accurately reflected according to the design guidance.
• Ensure I haven't ruined someone's day from the tests I updated.

[netlify]

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: ff85c37

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f977c584bd6e0008b74ab6

😎 Browse the preview: https://deploy-preview-10532--carbon-react-next.netlify.app

[netlify]

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: ff85c37

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f977c59e710b0008b21887

😎 Browse the preview: https://deploy-preview-10532--carbon-components-react.netlify.app/

[netlify]

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: ff85c37

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f977c5f534600007d9fa01

😎 Browse the preview: https://deploy-preview-10532--carbon-elements.netlify.app

[jnm2377]

Is the v11 icon button story supposed to be broken? It's missing the icon.

[sstrubberg]

Is the v11 icon button story supposed to be broken? It's missing the icon.

Yeah, i noticed that before I even started working on this. Up to ya'll if we want to get this in and then deal with the icon button or get it bundled in this PR.

[sstrubberg]

Is the v11 icon button story supposed to be broken? It's missing the icon.

Yeah, i noticed that before I even started working on this. Up to ya'll if we want to get this in and then deal with the icon button or get it bundled in this PR.

Cancel that. I think it's from when i merged something from main