Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(button): skeleton size prop audit #10559

Merged

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Jan 31, 2022

REF 10295

  • Added FeatureFlag ternary for ButtonSkeleton size prop based on guidance provided by design. REF
  • Removed the defaultProps object and moved them into default params. REF
  • Updated the public snappy and other tests because i moved the defaultProps.

Testing

  • Make sure Button is behaving correctly in the v11 & v10 storybooks and that size props are accurately reflected according to the design guidance.
  • Ensure I haven't ruined someone's day from the tests I updated.

@sstrubberg sstrubberg requested review from a team as code owners January 31, 2022 15:44
@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 5018193

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6203ac576cf3090007b084dc

😎 Browse the preview: https://deploy-preview-10559--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 5018193

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6203ac5717041c000734b984

😎 Browse the preview: https://deploy-preview-10559--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 5018193

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6203ac5747206d0008141508

😎 Browse the preview: https://deploy-preview-10559--carbon-components-react.netlify.app

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sstrubberg sstrubberg merged commit c0ca44a into carbon-design-system:main Feb 9, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 10, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants