Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): do not spread autoOrientation onto dom element #10611

Conversation

tay1orjones
Copy link
Member

Closes #10604

Changelog

Changed

  • Destructure autoOrientation in tooltip props to ensure it's not spread onto dom element

Testing / Reviewing

  • Passing the autoOrientation prop to tooltip should no longer pop a console warning
Warning: React does not recognize the `autoOrientation` prop on a DOM element.

@tay1orjones tay1orjones requested a review from a team as a code owner February 1, 2022 18:02
@netlify
Copy link

netlify bot commented Feb 1, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: a458520

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61faab4656baa600089b0ba2

😎 Browse the preview: https://deploy-preview-10611--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 1, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: a458520

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61faab462a45ee0008bbb6f3

😎 Browse the preview: https://deploy-preview-10611--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 1, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: a458520

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61faab467ff9370007e78787

😎 Browse the preview: https://deploy-preview-10611--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 47683d8 into carbon-design-system:main Feb 2, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 10, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tooltip: React does not recognize the autoOrientation prop on a DOM element
3 participants