Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(grid): remove narrow mode from CSS Grid implementation #10621

Merged
merged 4 commits into from
Feb 11, 2022
Merged

refactor(grid): remove narrow mode from CSS Grid implementation #10621

merged 4 commits into from
Feb 11, 2022

Conversation

tay1orjones
Copy link
Member

Closes #10620

This removes the narrow grid mode from the CSS Grid implementation. More context in the linked issue.

Changelog

Removed

  • remove narrow grid mode from CSS Grid implementation

Testing / Reviewing

  • v11 storybook stories and docs should no longer show narrow mode. Other examples should be unaffected.
  • v10 storybook experimental CSS story should no longer show narrow mode. Other examples should be unaffected.
  • Grid elements package example/preview should no longer show narrow mode. Other examples should be unaffected.

@tay1orjones tay1orjones requested a review from joshblack February 2, 2022 21:19
@tay1orjones tay1orjones requested a review from a team as a code owner February 2, 2022 21:19
@tay1orjones tay1orjones requested a review from abbeyhrt February 2, 2022 21:19
@netlify
Copy link

netlify bot commented Feb 2, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3dbde1d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6206be961cc7e30007d8e8cd

😎 Browse the preview: https://deploy-preview-10621--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 2, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 3dbde1d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6206be96dbc9680008fb44f3

😎 Browse the preview: https://deploy-preview-10621--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Feb 2, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3dbde1d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6206be961f2e3000074b5b76

😎 Browse the preview: https://deploy-preview-10621--carbon-elements.netlify.app

abbeyhrt
abbeyhrt approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jnm2377 jnm2377 enabled auto-merge (squash) February 11, 2022 19:52
@jnm2377 jnm2377 merged commit 8a07838 into carbon-design-system:main Feb 11, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 14, 2022
Closed
22 tasks
@tay1orjones tay1orjones mentioned this pull request Feb 25, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove narrow grid mode from CSS Grid implementation
4 participants
@tay1orjones @joshblack @abbeyhrt @jnm2377