Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aspect-ratio): update aspect ratio docs for v11 #10636

Conversation

joshblack
Copy link
Contributor

This PR introduces two updates to our storybook for v11:

  • Grid storybook styles are now scoped to a storybook-specific class name
  • The Aspect Ratio story has been updated and includes controls

Changelog

New

  • The AspectRatio story has been updated and now uses controls

Changed

  • The Grid storybook styles are now scoped

Removed

Testing / Reviewing

  • Verify no regression exists between the current grid storybook styles and the ones in this PR
  • Verify the AspectRatio story renders as intended (correct aspect ratio and background color per item)
    • Also, verify the controls work when switching the "ratio" prop

@joshblack joshblack requested a review from a team as a code owner February 3, 2022 18:22
@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3911026

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/620a8061c54fb60007d285e1

😎 Browse the preview: https://deploy-preview-10636--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 3911026

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/620a8060afeb720007b2bf91

😎 Browse the preview: https://deploy-preview-10636--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3911026

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/620a806032021c0007f9ac03

😎 Browse the preview: https://deploy-preview-10636--carbon-elements.netlify.app

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only change I think it needs is the aspect ratio story css only works for v10, we could just add an additional selector with cds or use prefix:

.aspect-ratio-story .bx--aspect-ratio {

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we're missing the purple boxes

image

@joshblack
Copy link
Contributor Author

Thanks for the catch @jnm2377 @tay1orjones! Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants