Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Pagination): sync styles between v10 and v11 #10638

Merged
merged 3 commits into from
Feb 8, 2022
Merged

fix(Pagination): sync styles between v10 and v11 #10638

merged 3 commits into from
Feb 8, 2022

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Feb 3, 2022

Closes #10631

Small tweaks based on style audit

Testing / Reviewing

Ensure the V10 and V11 Pagination components render identically

@tw15egan tw15egan requested a review from a team as a code owner February 3, 2022 20:22
@netlify
Copy link

netlify bot commented Feb 3, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: b718925

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6202a0c6f1425f000834bbc2

😎 Browse the preview: https://deploy-preview-10638--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 3, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: b718925

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6202a0c65042700007bcc12c

😎 Browse the preview: https://deploy-preview-10638--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Feb 3, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: b718925

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6202a0c65042700007bcc131

😎 Browse the preview: https://deploy-preview-10638--carbon-elements.netlify.app

abbeyhrt
abbeyhrt approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

aledavila
aledavila approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit e69ff16 into carbon-design-system:main Feb 8, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 10, 2022
Closed
22 tasks
@tw15egan tw15egan deleted the pagination-tweaks branch March 3, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@aledavila aledavila aledavila approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit pagination styles
3 participants
@tw15egan @aledavila @abbeyhrt