Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(listbox): conditionally apply new size prop options, update story… #10640

Merged
merged 3 commits into from
Feb 9, 2022
Merged

fix(listbox): conditionally apply new size prop options, update story… #10640

merged 3 commits into from
Feb 9, 2022

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Feb 3, 2022 •
edited
Loading

Part of #10295

Ensure the listbox size prop updates for v11 are correct

Changelog

New

  • Add size control for listbox component storybook stories

Changed

  • conditionally apply new proptype values for listbox based on changes in v11

Removed

  • remove unused xl styles from listbox and dropdown in packages/styles

Testing / Reviewing

  • In the v11 storybook, stories for the listbox components (ComboBox, Dropdown, MultiSelect, FilterableMultiSelect) should have a size control
  • The size control should mirror the same experience in the v10 storybook
  • Verify no defects in sizing to these components

@tay1orjones tay1orjones requested a review from a team as a code owner February 3, 2022 23:01
@netlify
Copy link

netlify bot commented Feb 3, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4569db0

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6203e9a13a92b00008a62588

😎 Browse the preview: https://deploy-preview-10640--carbon-react-next.netlify.app

@tay1orjones
Copy link
Member Author

tay1orjones commented Feb 3, 2022 •
edited
Loading

@aagonzales I'd like to double check here - for listbox components we're only supporting values of sm md and lg in v11, correct? It's what's on the v11 website https://v11.carbondesignsystem.com/components/dropdown/style#sizes

@tay1orjones tay1orjones mentioned this pull request Feb 3, 2022
Closed
36 tasks
@netlify
Copy link

netlify bot commented Feb 3, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4569db0

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6203e9a1970aac0007ae4f20

😎 Browse the preview: https://deploy-preview-10640--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 3, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4569db0

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6203e9a116f3d40007634fbc

😎 Browse the preview: https://deploy-preview-10640--carbon-components-react.netlify.app

dakahn
dakahn approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me! Tested on Ubuntu in Firefox latest 👍🏾

@kodiakhq kodiakhq bot merged commit aee822d into carbon-design-system:main Feb 9, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 10, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tay1orjones @joshblack @dakahn