Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): update gap to use correct spacing 07, add v11 story #10645

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

tay1orjones
Copy link
Member

Based on new guidance from design, spacing07 will be the recommended default spacing between form items/fields moving forward.

This PR updates the v11 form spacing examples using Stack to use gap={7} between fields.

Changelog

New

  • added v11 story for FormGroup

Changed

Testing / Reviewing

  • v11 storybook button stories should have no width regressions
  • v11 storybook FormGroup story should have 32px/spacing-07 between fields
  • v11 storybook FormGroup story button have a width relative to the content (intrinsic) width (not 100% width or the 20rem max-width as described in [Bug]: Button has incorrect width when placed in Stack #10644)
  • v11 storybook Form story button should also have intrinsic width

@tay1orjones tay1orjones requested a review from a team as a code owner February 4, 2022 20:51
@netlify
Copy link

netlify bot commented Feb 4, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: b3f06ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/62030e5f710e920008ea0ff4

😎 Browse the preview: https://deploy-preview-10645--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 4, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: b3f06ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/62030e5f63e3220008ff7397

😎 Browse the preview: https://deploy-preview-10645--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 4, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: b3f06ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/62030e5fbdf0ba0008789d3c

😎 Browse the preview: https://deploy-preview-10645--carbon-components-react.netlify.app

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

@kodiakhq kodiakhq bot merged commit addd1a7 into carbon-design-system:main Feb 9, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 10, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Button has incorrect width when placed in Stack
4 participants