-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form): update gap to use correct spacing 07, add v11 story #10645
fix(form): update gap to use correct spacing 07, add v11 story #10645
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: b3f06ca 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/62030e5f710e920008ea0ff4 😎 Browse the preview: https://deploy-preview-10645--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: b3f06ca 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/62030e5f63e3220008ff7397 😎 Browse the preview: https://deploy-preview-10645--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: b3f06ca 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/62030e5fbdf0ba0008789d3c 😎 Browse the preview: https://deploy-preview-10645--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ✅
Based on new guidance from design,
spacing07
will be the recommended default spacing between form items/fields moving forward.This PR updates the v11 form spacing examples using
Stack
to usegap={7}
between fields.Changelog
New
Changed
Button
has incorrect width when placed inStack
#10644)Testing / Reviewing
Button
has incorrect width when placed inStack
#10644)