-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(react): change import to populate props table for notification #10655
docs(react): change import to populate props table for notification #10655
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: fce580c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/620183405d197b0007c60f1c 😎 Browse the preview: https://deploy-preview-10655--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: d7ff172 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/620158b530e8a000070353b3 😎 Browse the preview: https://deploy-preview-10655--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: d7ff172 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/620158b50782f40007bad016 😎 Browse the preview: https://deploy-preview-10655--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: fce580c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/62018340c248700007ad125b 😎 Browse the preview: https://deploy-preview-10655--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: fce580c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/62018340c69a1600070cef29 😎 Browse the preview: https://deploy-preview-10655--carbon-components-react.netlify.app |
Nice and easy fix! Found a few more that are also solved by changing the import (#10656), nice find 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I'll keep an eye out for things like this
Updates where the notification components are imported from so that the props table populates as expected.
Testing/Reviewing
Go to notification story docs and check that the props shows notification's props for
Toast
andInline