-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(select): add playground story, controls #11623
docs(select): add playground story, controls #11623
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Playing around with the playground and I ran into a couple of quirks:
- When using
invalid
, I cannot setinvalidText
because it is of typenode
, trying to set it as a string breaks the playground and I have to refresh - Same issue as above with
labelText
- Same issue as above with
warnText
Setting those 3 that @joshblack mentioned as below should fix that
|
@aledavila @dakahn @joshblack Fixed 👍 , also pulled out the unnecessary non-ui-impacting props as we discussed |
Closes #11466
Changelog
New
bool
props inSelect
Changed
args
Removed
Testing / Reviewing