Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(select): add playground story, controls #11623

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

tay1orjones
Copy link
Member

Closes #11466

Changelog

New

  • Add defaults for bool props in Select

Changed

  • remove args/controls from non-playground stories
  • add args and playground story
  • provide defaults for controls via args

Removed

  • {{removed thing}}

Testing / Reviewing

  • Select stories should look and function, controls should only work on Playground story
  • Playground story controls should function as expected when changed/interacted

@tay1orjones tay1orjones requested a review from a team as a code owner June 15, 2022 21:32
@tay1orjones tay1orjones requested review from joshblack and dakahn June 15, 2022 21:32
@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5440678
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62b4dddef367c800093b924f
😎 Deploy Preview https://deploy-preview-11623--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5440678
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62b4ddde33cf6d00090543a5
😎 Deploy Preview https://deploy-preview-11623--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playing around with the playground and I ran into a couple of quirks:

  • When using invalid, I cannot set invalidText because it is of type node, trying to set it as a string breaks the playground and I have to refresh
  • Same issue as above with labelText
  • Same issue as above with warnText

@aledavila
Copy link
Contributor

Setting those 3 that @joshblack mentioned as below should fix that

invalidText: { control: 'text', },

@tay1orjones tay1orjones requested a review from joshblack June 22, 2022 19:09
@tay1orjones
Copy link
Member Author

@aledavila @dakahn @joshblack Fixed 👍 , also pulled out the unnecessary non-ui-impacting props as we discussed

@kodiakhq kodiakhq bot merged commit 2623b63 into carbon-design-system:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

components/Select/next/Select.stories.js
4 participants