-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TimePicker): add typescript typings #13206
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GalvinGao 👋🏼
Thanks for getting this PR up!
Mostly LGTM, looks like TimePickerSelect
changes are being picked up as a file deletion/addition, @GalvinGao did you use the gh mv
script as per described in the Steps to provide baseline type definitions for components ? if not, could you? 🙏🏻
packages/react/src/components/TimePickerSelect/TimePickerSelect.tsx
Outdated
Show resolved
Hide resolved
Hi @francinelucca! Thanks for reviewing this PR. I've corrected the copyright part & also added myself to the However for the deletion+addition issue, I've tried to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
use `as any` instead of type assertion to ensure backward compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for making that change 👍
Closes #12563
Adds TypeScript typings to
TimePicker
andTimePickerSelect
.Changelog
New
TimePicker
andTimePickerSelect
.Changed
N/A
Removed
N/A
Testing / Reviewing
By using the storybook, the maintainer may navigate to
/?path=/story/components-timepicker--default
on their local storybook instance to see that the component successfully renders with the provided stories. A screenshot is attached for reference.