-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabs): support contextual layout tokens (size & density) #13951
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@aagonzales I want to tag you here as well as there are some differences percy reported. It looks like the labels in line tabs are not 100% centered in main right now due to a difference in padding: Would love it if you could have a look at the implementation of this PR and see whether this achieves the desired visuals. |
@aagonzales I pushed an update positioning the label 1px lower. Checking with the latest Figma library I see an exact overlay now. Let me know if this works! |
@janhassel yup that's it! Matches up perfectly now. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed this review! LGTM once merge conflict is resolved 👍🏻 ✅
@tw15egan I just resolved the merge conflict. I think the percy approval is the last failing check now. |
Ref #13923
Adds support for contextual layout tokens to
Tabs
.Changelog
Changed
size
anddensity
groupsTesting / Reviewing
Locally run storybook
layout.size
with sm, md, lg (default: md)layout.density
layout.size
with sm, md, lg (default: md)layout.size
with sm, md, lg, xl (default: lg)layout.density
layout.density
layout.size
with lg, xl (default: xl)layout.density
<Tab iconSize="lg">
lg