fix(DataTable): fix stacking issues with table toolbar + batch actions #14275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Jul 21, 2023
alisonjoseph
requested review from
a team and
thyhmdo
and removed request for
a team
|
@thyhmdo For comparison @ 10% speed -- Old animation: New animation: It slides a little bit further down but allows longer tooltips in the batch action toolbar. Added an opacity transition so it is less noticeable |
tay1orjones
approved these changes
Jul 24, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14137
Adds some
z-indexvalues so that the batch actions and toolbars render over table content. Also tweaked theclip-patha bit so that longer tooltips can be rendered. This very slightly adjusts how much the toolbar slides down when fading in/out, but seems like a good compromise. Also addedopacitytransition to make this less noticeable.Changelog
New
z-indexadded to batch action bar, table toolbarChanged
clip-pathto allow longer tooltips in batch action barTesting / Reviewing
Go to the batch actions story, and add a much longer string for the tooltips that appear. Ensure the animations look correct and there are no regressions