fix(password-input): apply layout size class #14603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
approved these changes
Sep 8, 2023
alisonjoseph
approved these changes
Sep 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
misiekhardcore
pushed a commit
to misiekhardcore/carbon
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported via slack in #carbon-react: https://stackblitz.com/edit/github-4r9kha?file=src%2FApp.jsx
The PasswordInput currently isn't responding to the size prop since it doesn't apply the appropriate layout class.
Changelog
Changed
Testing / Reviewing
Pull this PR, locally run storybook, apply a valid size to the
TogglePasswordVisibilitystory. The size should adapt accordingly.