Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Notification): label notification with subtitle if title not present #14609

Merged

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Sep 8, 2023

Closes #14605

If title is not present, use subtitle instead

Changelog

Changed

  • Autogenerate a subtitleId and use that if a title is not present to set the aria-labelledby on the alertdialog

Testing / Reviewing

Don't pass in a title and ensure no a11y violations are found

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit e3e74b8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/64fb28144e3276000888abb2
😎 Deploy Preview https://deploy-preview-14609--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e3e74b8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64fb28141769a20008a31b17
😎 Deploy Preview https://deploy-preview-14609--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting issue. I wonder if we have any other areas in the system that rely on optional props for values in aria-labelledby.

@tay1orjones tay1orjones added this pull request to the merge queue Sep 14, 2023
Merged via the queue into carbon-design-system:main with commit 811767b Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: ActionableNotification aria-label should have more flexibility
3 participants