refactor(Slug): refactor Slug callout into composable components #15036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
force-pushed
the
ai-slug-refactor
branch
from
e93f56f to
3144217
Compare
|
@tw15egan Can we had a control in the storybook playground to turn on and off the action bar? |
|
@aagonzales Yeah definitely, I can add something to turn it off. For now, the first two normal slugs (mini and 2xs) in the default story don't have the toolbar. |
|
@aagonzales updated 👍🏻 |
aagonzales
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
The action group looks good!
This is just a side note for me, in the dark themes the gradient and toolbar kind of blend together. So I may tweak that later for visuals but everything looks to spec here. The gradient also isn't blending out as nicely at top so I'm going to look into that too.
alisonjoseph
approved these changes
Oct 30, 2023
alisonjoseph
added
status: one more review 👀
and removed
status: visual review 🔍
labels
tay1orjones
approved these changes
Oct 30, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
tay1orjones
removed this pull request from the merge queue due to the queue being cleared
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Nov 1, 2023
…bon-design-system#15036) * feat(Slug): scaffold out AI Slug component * feat(slug): add gradient tokens to themes, hover styles * feat(slug): add focus styles, cleanup storybook * fix(Theme): adjust small slug hover tokens * feat(Slug): add hollow slug * feat(Slug): initial inline styles * chore(snapshot): update snapshots * feat(Slug): add inline styles * fix(Slug): refactor inline variant * style(Slug): tweak inline styles * style(Slug): add hover styles to inline variant * style(Slug): add initial callout styles * style(Slug): tokenize gradients * style(Slug): adjust padding * chore: udpate snapshots * style(Slug): adjust padding with hollow dot, fix text colors * fix(Slug): fix hover styles when focused * refactor(Slug): remove ai from prefix * refactor(Slug): break Slug callout into composable components * style(Slug): add styles for action bar * chore(storybook): update stories to use SlugContent, SlugToolbar * refactor(Slug): rename SlugToolbar to SlugActions * chore(storybook): remove console.log * chore(storybook): add storybook toggle to show / hide action bar --------- Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: Taylor Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15051
Refs #14947
This is a continuation of the initial
SlugPR that adds in the action bar to theSlugcallout.Changelog
New
Slugaction barSlugis now composed similarly toToggletip, with aSlugContentcomponent mapping toToggletipContentandSlugActionsmapping toToggletipActions.Testing / Reviewing
Ensure that all
hollowSlug's only render the default callout, and all others render the new callout styles. Ensure there are no visual regressions.