feat(containedlist): added index.ts file for type generation #16302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Gururajj77
added
status: ready for review 👀
component: contained-list
area: typescript
and removed
area: typescript
labels
tay1orjones
approved these changes
May 8, 2024
| @@ -199,4 +204,6 @@ ContainedList.propTypes = { | |||
| size: PropTypes.oneOf(['sm', 'md', 'lg', 'xl']), | |||
| }; | |||
|
|
|||
| ContainedList.ContainedListItem = ContainedListItem; | |||
There was a problem hiding this comment.
This threw me for a loop, I thought we had deprecated all instances where we were placing subcomponents as fields on the parent component object. Turns out this has been in there since the inception of this component.
It's not something we need to do in this PR, but I think it would make sense to deprecate this like we did for TextInput.PasswordInput here
// what's currently possible, a bit out of convention
<ContainedList>
<ContainedList.ContainedListItem/>
<ContainedList.ContainedListItem/>
</ContainedList>
// following the general convention we have would mean
// it wouldn't be a field on the object. The above
// wouldn't work, instead:
<ContainedList>
<ContainedListItem/>
<ContainedListItem/>
</ContainedList>I can open a new issue for this 👍
Merged
via the queue into
carbon-design-system:main
with commit May 9, 2024
e70f08d
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16206
Added index.ts for index.d.ts type generation
Changelog
New
Changed
ContainedListItemRemoved
Testing / Reviewing
No new perspectives for testing.