Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(radiobuttongroup): provide unique names for each story #16356

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented May 8, 2024

Reported on slack

In storybook docs pages there can be more than one RadioButtonGroup on the page, each of which should have their own unique name.

Changelog

Changed

  • update formgroup and radiobutton stories to have story-unique name values

Testing / Reviewing

  • Go to the FormGroup overview story - the radio buttons should only require one click to be selected. The bug was that these required two clicks.

@tay1orjones tay1orjones self-assigned this May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 078b51d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/663bab1dc855d10008279fd0
😎 Deploy Preview https://deploy-preview-16356--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones marked this pull request as ready for review May 8, 2024 20:07
@tay1orjones tay1orjones requested a review from a team as a code owner May 8, 2024 20:07
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guidari guidari added this pull request to the merge queue May 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2024
@alisonjoseph alisonjoseph added this pull request to the merge queue May 13, 2024
Merged via the queue into carbon-design-system:main with commit 28393e6 May 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants