refactor(16054): Normalize usage of types | replace ReactNodeLike with ReactNode #16453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2nikhiltom
changed the title
2nikhiltom
changed the title
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
approved these changes
May 13, 2024
alisonjoseph
approved these changes
May 13, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 13, 2024
9230a09
20 checks passed
2 tasks
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16449 -
CheckBoxCloses #16450 -
ComposedModalCloses #16451 -
TableHeaderCloses #16452 -
TableSlugRowThis PR fixes inconsistencies and Normalizes the usage of types
ReactNodeandReactNodeLikein components .Now the component props accept ReactNode instead of ReactNodeLike
Changelog
Changed from
ReactNodeLiketoReactNodeTesting / Reviewing
This should not require any visual/functional testing, please verification if the existing functionality is intact.