Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(multiselect): do not select disabled items on "select all" button #16477

Merged

Conversation

ychavoya
Copy link
Contributor

Closes #16445

Changelog

Changed

  • Updated an example in the storybook to prevent selecting a disabled item in the Controlled MultiSelect story

Testing / Reviewing

Open the "Multiselect / Controlled" story in the storybook and click on the "Select All" button, the disabled items should not be selected

@ychavoya ychavoya requested a review from a team as a code owner May 15, 2024 15:17
@ychavoya ychavoya requested review from alisonjoseph and guidari May 15, 2024 15:17
Copy link

netlify bot commented May 15, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d51da4f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6644d2001c423700082be3a2
😎 Deploy Preview https://deploy-preview-16477--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tay1orjones tay1orjones added this pull request to the merge queue May 15, 2024
Merged via the queue into carbon-design-system:main with commit e273434 May 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiselect Controlled state is selecting disabled items
3 participants