Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combobox): initial setup for floating-ui addition #16566

Closed

Conversation

Gururajj77
Copy link
Contributor

Closes #16470

added floating-ui for ComboBox

Changelog

New

  • importing floating-ui items and setting ready up

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented May 24, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8748836
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/665421c4cb83170008a38352
😎 Deploy Preview https://deploy-preview-16566--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 24, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8748836
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/665421c41324d20008fd846e
😎 Deploy Preview https://deploy-preview-16566--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gururajj77
Copy link
Contributor Author

New PR for this with updated code on #16585

@Gururajj77 Gururajj77 closed this May 28, 2024
@Gururajj77 Gururajj77 deleted the floating-ui-combobox branch June 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add floating-ui to @carbon/react ComboBox
1 participant