-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: floating ui on combobutton #16586
fix: floating ui on combobutton #16586
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
aa51092
Closes #16540
This PR enhances ComboButton experimental autoAlign functionality to automatically position the floating element to be within view, even on scroll.
This uses floating-ui and relies solely on the fixed strategy, using position: fixed on the floating element. In the majority of cases, ComboButton floating elements will no longer be clipped by parents with overflow: hidden.
Changed
Removed
Testing / Reviewing