feat: add types to CheckboxGroup component #16643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
riddhybansal
approved these changes
Jun 5, 2024
preetibansalui
approved these changes
Jun 5, 2024
alisonjoseph
approved these changes
Jun 6, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jun 6, 2024
93740ff
21 checks passed
|
'"@carbon/react"' has no exported member named 'CheckboxGroup'. Did you mean 'CheckboxProps'?ts(2724) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16584
Add types to CheckboxGroup
Changelog
New
Added interfaces for props, state and internal variables.
Changed
renamed CheckboxGroup.js to CheckboxGroup.tsx
Testing / Reviewing
building
viewing the CheckboxGroup stories
creating a component that uses CheckboxGroup and testing which props are valid/invalid