-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: textarea invalid icon #16725
fix: textarea invalid icon #16725
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, just a minor formatting update suggestion.
Co-authored-by: Alison Joseph <[email protected]>
Am not sure of it may be @alina-jacob would be a right person to answer this. |
Hi @preetibansalui and @riddhybansal, good catch on the word-counter! The screenshot one is a bug, the counter would sit on the right-edge of the text-area (parallel to the lable, above the input field), not in the far right corner Here's the spec for it: Website link |
For this , will be creating another issue. |
8dd1cf5
Closes #16355
Closes #16649
Error icon appears outside of the textarea element when user passes cols property to TextArea component
Changelog
Changed
Testing / Reviewing
Pass cols prop in Textarea component
Set invalid prop to true, The icon should lie in the textarea itself