Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: textarea invalid icon #16725

Merged

Conversation

riddhybansal
Copy link
Contributor

@riddhybansal riddhybansal commented Jun 9, 2024

Closes #16355
Closes #16649

Error icon appears outside of the textarea element when user passes cols property to TextArea component

Changelog

Changed

  • Some styles.

Testing / Reviewing

Pass cols prop in Textarea component
Set invalid prop to true, The icon should lie in the textarea itself

@riddhybansal riddhybansal requested a review from a team as a code owner June 9, 2024 13:53
Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit aa294b8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6665b3bdcbc1280008135b3b
😎 Deploy Preview https://deploy-preview-16725--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit aa294b8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6665b3bdd415a7000854b4a4
😎 Deploy Preview https://deploy-preview-16725--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 536b25b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/666af631afe28b0008afb14c
😎 Deploy Preview https://deploy-preview-16725--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 536b25b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/666af631302c190008aea155
😎 Deploy Preview https://deploy-preview-16725--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, just a minor formatting update suggestion.

packages/react/src/components/TextArea/TextArea.tsx Outdated Show resolved Hide resolved
@preetibansalui
Copy link
Contributor

image Hey, a minor thing I noticed, Is it ok that if it shows the number of characters out of the box?

@riddhybansal
Copy link
Contributor Author

image Hey, a minor thing I noticed, Is it ok that if it shows the number of characters out of the box?

Am not sure of it may be @alina-jacob would be a right person to answer this.

@alina-jacob
Copy link
Member

alina-jacob commented Jun 12, 2024

Hi @preetibansalui and @riddhybansal, good catch on the word-counter!
Its supposed to re-size based the width of the text area

The screenshot one is a bug, the counter would sit on the right-edge of the text-area (parallel to the lable, above the input field), not in the far right corner

Here's the spec for it: Website link
image

@2nikhiltom 2nikhiltom self-requested a review June 13, 2024 08:07
@riddhybansal
Copy link
Contributor Author

Hi @preetibansalui and @riddhybansal, good catch on the word-counter! Its supposed to re-size based the width of the text area

The screenshot one is a bug, the counter would sit on the right-edge of the text-area (parallel to the lable, above the input field), not in the far right corner

Here's the spec for it: Website link image

For this , will be creating another issue.

@riddhybansal riddhybansal added this pull request to the merge queue Jun 13, 2024
Merged via the queue into carbon-design-system:main with commit 8dd1cf5 Jun 13, 2024
22 checks passed
@riddhybansal riddhybansal deleted the TextArea_Invalid_icon_bug branch June 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants