fix: combobox not showing correct highlight #16741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2nikhiltom
reviewed
Jun 17, 2024
There was a problem hiding this comment.
This is looking great 💯 .
Small query : same behaviour is seen when allowCustomval is set to true. is this expected ?
Screen.Recording.2024-06-17.at.09.09.35.mov
- Open combobox and select an option, eg - 'option 2'
- It should display 'option 2' in input field.
- Now change input text to 'option', it should highlight the loosely match item from options.
- Blur the input by clicking outside of input field
- now open the combobox again, it should highlight the 'option 2' and input text should be 'option 2' as well.
When allowCustomValue is true, at step 5, should it highlight 'option 2' and also set the input text to 'option 2', or should it keep the custom value instead?
alisonjoseph
approved these changes
Jun 17, 2024
tay1orjones
approved these changes
Jun 20, 2024
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Jun 21, 2024
757a4af
22 checks passed
tay1orjones
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Jun 21, 2024
* fix: combobox not showing correct highlight * fix: removed console
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16474
Combobox not showing correct highlight
Testing / Reviewing