fix: web componet dynamic row changes #17895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17895 +/- ##
==========================================
+ Coverage 80.45% 80.49% +0.04%
==========================================
Files 406 406
Lines 14041 14041
Branches 4347 4395 +48
==========================================
+ Hits 11296 11302 +6
+ Misses 2579 2572 -7
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
kennylam
requested review from
emyarod,
ariellalgilmore and
annawen1
and removed request for
alisonjoseph
ariellalgilmore
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
LGTM! also looks like it fixes this reported bug as well: #17660
kennylam
approved these changes
Oct 30, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 30, 2024
75c827d
40 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17894
Rows changed dynamically, e.g. by pagination, make the internals of
cds-tablestale. Specifically things likeexpandableare not persisted between pages.Changelog
Changed
Playgroundstory to simulate changing rows at runtime.cds-table-body-content-changefrom table body when the slot contents change.cds-table-body-content-change.Testing / Reviewing
Verified in altered storybook story.