Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed value to be return and removed unnecessary value #18012

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Nov 7, 2024

Closes #18008

Added the value to be returned in the function
Removed unnecessary value in the onChange

Screenshot 2024-11-07 at 11 26 43

Testing / Reviewing

  • Test the Playground stories from Filtering variant
  • Check Actions section

@guidari guidari requested a review from a team as a code owner November 7, 2024 14:28
@guidari guidari requested review from kennylam and annawen1 November 7, 2024 14:28
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 8e55fac
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/672cce7290b2840008791d1b
😎 Deploy Preview https://deploy-preview-18012--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 7bcd6e4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/672cce7623a9f30008631331
😎 Deploy Preview https://deploy-preview-18012--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8e55fac
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672cce725bd9810008a824b8
😎 Deploy Preview https://deploy-preview-18012--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8e55fac
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672cce7292a4140008b560e9
😎 Deploy Preview https://deploy-preview-18012--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7bcd6e4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672cce751b10db0008947de5
😎 Deploy Preview https://deploy-preview-18012--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (aa67ac9) to head (7bcd6e4).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18012      +/-   ##
==========================================
+ Coverage   81.78%   81.81%   +0.03%     
==========================================
  Files         406      404       -2     
  Lines       14048    14085      +37     
  Branches     4356     4360       +4     
==========================================
+ Hits        11489    11524      +35     
- Misses       2397     2399       +2     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7bcd6e4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672cce760cd7fd0008bc900f
😎 Deploy Preview https://deploy-preview-18012--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riddhybansal riddhybansal added this pull request to the merge queue Nov 11, 2024
Merged via the queue into carbon-design-system:main with commit 46a1cf6 Nov 11, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TableToolbarSearch onChange value is always undefined
3 participants