Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated storybook dependencies to v8.4.5 #18171

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Nov 28, 2024

Updated storybook to v8.4.5 to get the advantages of storybook v8.4 and other fixes

Docs: https://storybook.js.org/blog/storybook-8-4

Testing / Reviewing

  • CI should pass

@guidari guidari requested a review from a team as a code owner November 28, 2024 14:17
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit bae82a4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67489a1b2b54cb0008a86e15
😎 Deploy Preview https://deploy-preview-18171--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari self-assigned this Nov 28, 2024
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 46d1474
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67487b6efdc3e10008b97fc1
😎 Deploy Preview https://deploy-preview-18171--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 46d1474
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67487b6ebd42a10008812703
😎 Deploy Preview https://deploy-preview-18171--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bae82a4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67489a1b2b54cb0008a86e13
😎 Deploy Preview https://deploy-preview-18171--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bae82a4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67489a1b94f8460008ca400c
😎 Deploy Preview https://deploy-preview-18171--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (29d0f18) to head (bae82a4).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18171   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files         404      404           
  Lines       14344    14344           
  Branches     4650     4646    -4     
=======================================
  Hits        11958    11958           
- Misses       2224     2225    +1     
+ Partials      162      161    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🥳

@tay1orjones tay1orjones added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@guidari guidari added this pull request to the merge queue Dec 4, 2024
Merged via the queue into carbon-design-system:main with commit 296a891 Dec 4, 2024
40 checks passed
@guidari guidari deleted the storybook-update branch December 4, 2024 12:32
@carbon-automation
Copy link
Contributor

Hey there! v11.72.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants