-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: swap assert syntax with 'with' to accommodate Node >=22 #18236
chore: swap assert syntax with 'with' to accommodate Node >=22 #18236
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18236 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 404 404
Lines 14350 14350
Branches 4619 4649 +30
=======================================
Hits 12077 12077
Misses 2111 2111
Partials 162 162 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works with node 23 🚀
5b3df41
When running the web-components build on Node v23, the following line errors out
due to the "import assertions" no longer being supported. Fix is to use
with
instead. This will break in older Node versions like 16 || 17, but that doesn't matter as we specify Carbon needs >=18.Changelog
Changed
assert
keyword withwith
Testing / Reviewing
See that the ci-checks, especially the build, pass