-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updates the interface for DataTableHeader to include isSortable #18295
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18295 +/- ##
==========================================
- Coverage 84.17% 84.17% -0.01%
==========================================
Files 408 408
Lines 14434 14436 +2
Branches 4689 4691 +2
==========================================
+ Hits 12150 12151 +1
Misses 2120 2120
- Partials 164 165 +1 ☔ View full report in Codecov by Sentry. |
Closes #18172
Minor update to the DataTableHeader interface to handle a header having its own isSortable, instead of needing to be redeclared when passing into getHeaderProps.
I picked a random bug/feature to refresh my knowledge of contributing to Carbon. If this fix isn't wanted/needed, no problem.
Changelog
Testing / Reviewing