-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): resolve parity issues #18367
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18367 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 408 408
Lines 14435 14435
Branches 4660 4660
=======================================
Hits 12150 12150
Misses 2120 2120
Partials 165 165 ☔ View full report in Codecov by Sentry. |
Closes #17931 #18164
Resolved a few parity issues
Changelog
Changed
Testing / Reviewing
select
playground storybookselect
element using the browser dev tools and select anyoption
by putting theselected
attributevalue
prop from controls to give thevalue
prop to the componentThis way we can verify all cases mentioned in the table.
with AI label
sub-story from theselect
storybookwith AI label
sub-story from theselect
storybooktab
button and compare the focus border thickness with the corresponding React storybookNote Also verify this style from the
AI Label
component storybook