Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): resolve parity issues #18367

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

makafsal
Copy link
Member

@makafsal makafsal commented Jan 16, 2025

Closes #17931 #18164

Resolved a few parity issues

Changelog

Changed

Testing / Reviewing

Verify issue #18164
Please see the acceptance criteria table here

  1. Open select playground storybook
  2. Inspect the select element using the browser dev tools and select any option by putting the selected attribute
  3. Also, we can utilize the value prop from controls to give the value prop to the component
    This way we can verify all cases mentioned in the table.

Verify AI Label gradient

  1. Open the with AI label sub-story from the select storybook
  2. Then compare the gradient style with the corresponding React storybook

Verify AI button focus style

  1. Open the with AI label sub-story from the select storybook
  2. Then press the tab button and compare the focus border thickness with the corresponding React storybook

Note Also verify this style from the AI Label component storybook

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 8456f93
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6789ee816f7c650008c067a6
😎 Deploy Preview https://deploy-preview-18367--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8456f93
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6789ee81f6acee0008c6aedc
😎 Deploy Preview https://deploy-preview-18367--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8456f93
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6789ee81f90854000861ceaa
😎 Deploy Preview https://deploy-preview-18367--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@makafsal makafsal marked this pull request as ready for review January 16, 2025 15:37
@makafsal makafsal requested a review from a team as a code owner January 16, 2025 15:38
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (0c2ff15) to head (8456f93).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18367   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         408      408           
  Lines       14435    14435           
  Branches     4660     4660           
=======================================
  Hits        12150    12150           
  Misses       2120     2120           
  Partials      165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Select
2 participants