Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sketch): update shared color names to include space #5664

Merged
merged 3 commits into from
Mar 20, 2020
Merged

fix(sketch): update shared color names to include space #5664

merged 3 commits into from
Mar 20, 2020

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Mar 19, 2020 •
edited
Loading

Closes carbon-design-system/carbon-design-kit#267

Update shared style name to include spaces around the dividing /.

image

Changelog

New

Changed

  • Include space around dividing / in shared color names

Removed

@joshblack joshblack requested a review from a team as a code owner March 19, 2020 16:49
@ghost ghost requested review from aledavila and emyarod March 19, 2020 16:49
@joshblack joshblack requested a review from laurenmrice March 19, 2020 16:49
@laurenmrice laurenmrice mentioned this pull request Mar 19, 2020
Closed
@netlify
Copy link

netlify bot commented Mar 19, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit e152e90

https://deploy-preview-5664--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Mar 19, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit e152e90

https://deploy-preview-5664--carbon-elements.netlify.com

@laurenmrice
Copy link
Member

laurenmrice commented Mar 19, 2020 •
edited
Loading

Thanks for putting a space between the / !

We do not need a space though between the dashes and color name. gray - 40, for example. Those should be gray-40 with no space. This is how we are treating it for our color tokens when they have a dash, so I just want to stay consistent with that. 👍🏻

@joshblack
Copy link
Contributor Author

Lol, thanks for the catch @laurenmrice! I'll fix it 🤦‍♂️

@joshblack
Copy link
Contributor Author

@laurenmrice updated!

emyarod
emyarod approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joshblack joshblack merged commit 7aa0cab into carbon-design-system:master Mar 20, 2020
@joshblack joshblack deleted the 267-update-color-names branch March 20, 2020 17:18
@joshblack
Copy link
Contributor Author

Ah shoot, made the mistake of merging in too soon @aledavila

Let me know if you would want to go over this stuff and/or if you have any concerns about the e changes!

@aledavila
Copy link
Contributor

@joshblack no it seems good to me. Understanding more now

renmaddox pushed a commit to renmaddox/carbon that referenced this pull request Mar 20, 2020
@joshblack @renmaddox
fix(sketch): update shared color names to include space (carbon-desig…
26480c7 
…n-system#5664)

* fix(sketch): update shared color names to include space

* fix(sketch): update generate page command
renmaddox added a commit to renmaddox/carbon that referenced this pull request Mar 20, 2020
@renmaddox
Revert "fix(sketch): update shared color names to include space (carb…
a02851e 
…on-design-system#5664)"

This reverts commit 26480c7.
renmaddox added a commit to renmaddox/carbon that referenced this pull request Mar 20, 2020
@renmaddox
Revert "fix(sketch): update shared color names to include space (carb…
5ab2801 
…on-design-system#5664)"

This reverts commit 26480c7.
renmaddox pushed a commit to renmaddox/carbon that referenced this pull request Mar 20, 2020
@joshblack @renmaddox
fix(sketch): update shared color names to include space (carbon-desig…
abfb1fc 
…n-system#5664)

* fix(sketch): update shared color names to include space

* fix(sketch): update generate page command
@emyarod emyarod mentioned this pull request Mar 25, 2020
Closed
@emyarod emyarod mentioned this pull request Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@aledavila aledavila Awaiting requested review from aledavila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IDL v2 kit] need space between / for colors
4 participants
@joshblack @laurenmrice @aledavila @emyarod