feat(react): add aspect ratio component #7123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 7667f34 |
|
Deploy preview for carbon-components-react ready! Built with commit 7667f34 https://deploy-preview-7123--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 8f6c991 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 8f6c991 https://deploy-preview-7123--carbon-components-react.netlify.app |
|
Let me know if you have any questions @tw15egan @aledavila! |
tw15egan
approved these changes
Oct 26, 2020
aledavila
approved these changes
Oct 27, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
scottdickerson
added a commit
to scottdickerson/carbon
that referenced
this pull request
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in an
AspectRatioutility component in React 👀This component assists with rendering objects in specific aspect ratios as determined by our grid package.
Changelog
New
AspectRatiocomponent topackages/reactChanged
Removed