fix(tooltip): call parent with close when controlled #7600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 7be9e5e |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 7be9e5e https://deploy-preview-7600--carbon-components-react.netlify.app |
andreancardona
approved these changes
Jan 22, 2021
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7598
When a Tooltip was controlled, there was no way for the parent to understand if a user was trying to interact with it or not. This adds the same onChange callback that an uncontrolled Tooltip calls when the user is interacting. It's up to the parent to decide whether to close the tooltip or open it
Changelog
New
Changed
Removed
Testing / Reviewing
Verify that if you have a controlled Tooltip that you see the onChange callback get called in the story